VectorDataset: extract mint/maxt from filename

[oddeirikigland]

Opening PR after a discussion on Slack: https://torchgeo.slack.com/archives/C02DD9Q76SE/p1705589213060449

[adamjstewart]

Can you copy https://github.com/microsoft/torchgeo/blob/v0.5.1/torchgeo/datasets/geo.py#L323-L339 from RasterDataset to VectorDataset? You can remove these lines: https://github.com/microsoft/torchgeo/blob/v0.5.1/torchgeo/datasets/geo.py#L329-L333

We'll also need to add tests for this. I can point you to where these would be, but let me know if you need help.

[oddeirikigland]

@oddeirikigland please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

• (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.

@microsoft-github-policy-service agree

• (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.

@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

[oddeirikigland]

Can you copy https://github.com/microsoft/torchgeo/blob/v0.5.1/torchgeo/datasets/geo.py#L323-L339 from RasterDataset to VectorDataset? You can remove these lines: https://github.com/microsoft/torchgeo/blob/v0.5.1/torchgeo/datasets/geo.py#L329-L333

We'll also need to add tests for this. I can point you to where these would be, but let me know if you need help.

Added the docstring. I'll need some guidance for the tests, where is the similar test for RasterDataset?

[adamjstewart]

For testing, you'll want to edit tests/data/vector/data.py such that the generated fake file includes a year in the filename. Then edit CustomVectorDataset in tests/data/test_geo.py to add a filename_regex and date_format to match.

[oddeirikigland]

For testing, you'll want to edit tests/data/vector/data.py such that the generated fake file includes a year in the filename. Then edit CustomVectorDataset in tests/data/test_geo.py to add a filename_regex and date_format to match.

added test

[adamjstewart]

Looks pretty straightforward to me. Hopefully we'll get some builtin datasets that use this feature in the future. Not sure what kind of data your group is working with but would love to have it in TorchGeo if it's public. #1813 might actually use this feature too.

[oddeirikigland]

Looks pretty straightforward to me. Hopefully we'll get some builtin datasets that use this feature in the future. Not sure what kind of data your group is working with but would love to have it in TorchGeo if it's public. #1813 might actually use this feature too.

Perfect! Thank you for the help 😃 unfortunately, we cannot share the data we are working with. I see #1813 has tested the feature already so that can cover it 👌