Fix plotting in datamodules when dataset is a Subset #2003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaaccorley
approved these changes
Apr 16, 2024
|
I can confirm that with this change my plots show up in tensorboard 👍 |
|
Very clever, don't know why I never thought of this. Do any of our builtin datamodules suffer from this issue? Just want to make sure we have 100% test coverage. |
|
I've def experienced this issue, likely OSCD or levir |
|
Ah, I just noticed codecov actually works for this PR since it doesn't come from a fork. |
adamjstewart
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a
.plot(...)method in ourBaseDataModulethat routes plot requests from the trainers through to the dataset object's.plot(...)method. This currently only works iftrainer.datasetortrainer.val_datasethas a plot method. However, when you calltorch.utils.data.random_splitto get a train/val split, your dataset objects areSubsetswhich don't have a plot method.