Remove torchgeo.datamodules.utils.dataset_split #2005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
testing
|
Could be made simpler by allowing the user to input |
isaaccorley
reviewed
Apr 17, 2024
|
Let's merge this as is. We can think about renaming (lengths) or adding (random seed) parameters in a separate PR. |
adamjstewart
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function was added as a wrapper around
torch.utils.data.random_splitwith support for percentages. However, this feature was added upstream, and the minimum supported version of PyTorch now supports it. This wrapper can now be removed.There are no backwards incompatible changes since this function was never documented.