-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename bbox -> bounds #2199
Rename bbox -> bounds #2199
Conversation
I would also be okay with removing it entirely. We currently don't use it anywhere. The original intent was that it could be used for stitching together prediction patches, but we don't do that yet. But I like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me, hoping you can convince at least one more person to review the name choice so we don't end up changing it again later. Note that rtree supports both bounds
and bbox
for the same objects, but they have different meanings. This has always confused me.
I think |
Looks like rtree's bbox is just an interleaved bounds. We could also consider |
Based on popular vote, I think we'll stick with |
'bbox' in kornia augmentations is used to identify bounding boxes of instances in an image. However, in GeoDatasets, bbox refers to the geographic bounds of the data. This PR aims to make these distinct by renaming 'bbox' in GeoDatasets to 'geo_bbox'
bounds
could also be another option.