-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding the SeCo patch datasets #223
Conversation
1a9f5d7
to
f1b2af3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor comments, mostly just waiting on tests
@adamjstewart any idea why the doc test is failing with opencv? |
Doc tests are failing because |
Getting a "TclError" on the TestChesapeakeCVPRSegmentationTask.test_validation step related to matplotlib plotting even though I didn't change that code. |
This seems to be a transient failure, if you rerun the tests it should pass. I haven't tracked down a good way to prevent this test from failing yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You also need to update docs/api/datasets.rst
* Adding the SeCo patch datasets * Adding tests and incorporating suggestions * Added benchmark example code link * Update to new way of downloading * Formatting * Test coverage * Rename dataset * Add SeCo dataset to docs
No description provided.