Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the SeCo patch datasets #223

Merged
merged 8 commits into from
Nov 7, 2021
Merged

Adding the SeCo patch datasets #223

merged 8 commits into from
Nov 7, 2021

Conversation

calebrob6
Copy link
Member

No description provided.

Copy link
Collaborator

@adamjstewart adamjstewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comments, mostly just waiting on tests

torchgeo/datasets/seco.py Outdated Show resolved Hide resolved
torchgeo/datasets/seco.py Outdated Show resolved Hide resolved
torchgeo/datasets/seco.py Outdated Show resolved Hide resolved
@adamjstewart adamjstewart added the datasets Geospatial or benchmark datasets label Nov 5, 2021
@calebrob6
Copy link
Member Author

@adamjstewart any idea why the doc test is failing with opencv?

@adamjstewart
Copy link
Collaborator

Doc tests are failing because cv2 isn't installed when we build our docs, only required deps and train deps are installed.

@calebrob6
Copy link
Member Author

Getting a "TclError" on the TestChesapeakeCVPRSegmentationTask.test_validation step related to matplotlib plotting even though I didn't change that code.

@adamjstewart
Copy link
Collaborator

Getting a "TclError" on the TestChesapeakeCVPRSegmentationTask.test_validation step related to matplotlib plotting even though I didn't change that code.

This seems to be a transient failure, if you rerun the tests it should pass. I haven't tracked down a good way to prevent this test from failing yet.

torchgeo/datasets/seco.py Outdated Show resolved Hide resolved
torchgeo/datasets/seco.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@adamjstewart adamjstewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to update docs/api/datasets.rst

@adamjstewart adamjstewart merged commit b87d270 into main Nov 7, 2021
@adamjstewart adamjstewart deleted the dataset/seco branch November 7, 2021 04:58
@adamjstewart adamjstewart added this to the 0.1.0 milestone Nov 20, 2021
yichiac pushed a commit to yichiac/torchgeo that referenced this pull request Apr 29, 2023
* Adding the SeCo patch datasets

* Adding tests and incorporating suggestions

* Added benchmark example code link

* Update to new way of downloading

* Formatting

* Test coverage

* Rename dataset

* Add SeCo dataset to docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datasets Geospatial or benchmark datasets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants