Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempting to remove defaultdict from the collation functions #2398

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

calebrob6
Copy link
Member

@calebrob6 calebrob6 commented Nov 8, 2024

Having Dataloaders return batches as defaultdicts with "image", "mask", etc. keys causes problems:

Also, I don't see any particular benefit for our collation functions to returning defaultdicts vs. normal dicts.

@github-actions github-actions bot added the datasets Geospatial or benchmark datasets label Nov 8, 2024
@adamjstewart adamjstewart added this to the 0.6.2 milestone Nov 8, 2024
@adamjstewart adamjstewart merged commit fa69674 into main Nov 8, 2024
19 checks passed
@adamjstewart adamjstewart deleted the remove_defaultdict branch November 8, 2024 12:14
calebrob6 added a commit that referenced this pull request Dec 8, 2024
* Attempting to remove defaultdict from the collation functions

* Any(thing) goes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datasets Geospatial or benchmark datasets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants