Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sklearn dependency required #249

Merged
merged 2 commits into from
Nov 16, 2021
Merged

Conversation

ashnair1
Copy link
Collaborator

@ashnair1 ashnair1 commented Nov 16, 2021

Not sure if sklearn is now a mandatory requirement or an optional one for datasets. If the latter, a note needs to be added to cyclone.py and sen12ms.py

Fixes #230

@adamjstewart
Copy link
Collaborator

Thanks! I think my plan is to make everything that requires a top-level import to be a required dependency, meaning that only packages that are lazily imported can be optional. This will allow all files in TorchGeo to be imported as long as the core dependencies are installed. I'll make sure this happens before the next release.

@adamjstewart adamjstewart merged commit b81e0e7 into microsoft:main Nov 16, 2021
@ashnair1 ashnair1 deleted the sklearn-dep branch November 16, 2021 17:29
@adamjstewart adamjstewart added this to the 0.2.0 milestone Nov 20, 2021
@adamjstewart adamjstewart changed the title Fix #230 Make sklearn dependency required Dec 19, 2021
@adamjstewart adamjstewart modified the milestones: 0.2.0, 0.1.1 Dec 19, 2021
adamjstewart pushed a commit that referenced this pull request Dec 19, 2021
* Move sklearn to dataset optional reqs

* Move sklean to mandatory reqs
yichiac pushed a commit to yichiac/torchgeo that referenced this pull request Apr 29, 2023
* Move sklearn to dataset optional reqs

* Move sklean to mandatory reqs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing dep on sklearn
2 participants