Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plotting method for GID15 dataset #288

Merged
merged 4 commits into from
Dec 17, 2021
Merged

plotting method for GID15 dataset #288

merged 4 commits into from
Dec 17, 2021

Conversation

nilsleh
Copy link
Collaborator

@nilsleh nilsleh commented Dec 15, 2021 •
edited
Loading

Added plotting method for GID15 dataset.
Screenshot from 2021-12-16 21-33-24

@adamjstewart adamjstewart added the datasets Geospatial or benchmark datasets label Dec 15, 2021
@adamjstewart adamjstewart added this to the 0.2.0 milestone Dec 15, 2021
@isaaccorley
Copy link
Collaborator

Needs to add support for predicted masks.

@nilsleh
Copy link
Collaborator Author

nilsleh commented Dec 15, 2021

Needs to add support for predicted masks.

Sorry, I am not sure I understand. I thought the plot method is supposed to just show a sample from the dataset, and not any predictions?

@isaaccorley
Copy link
Collaborator

Sorry, I am not sure I understand. I thought the plot method is supposed to just show a sample from the dataset, and not any predictions?

We are in the process of updating all plotting methods for datasets as well as adding the ability to subplot a predicted target if it's in the sample dict (e.g. under the key "predictions"). See #264

@isaaccorley
Copy link
Collaborator

This looks good. Can you add some example plots to the PR description as a sanity check?

@calebrob6 calebrob6 merged commit 29dc789 into microsoft:main Dec 17, 2021
@calebrob6
Copy link
Member

Overriding the broken mypy check

@nilsleh nilsleh mentioned this pull request Dec 17, 2021
Merged
@adamjstewart
Copy link
Collaborator

I think the key should be "prediction", not "predictions". None of our other keys (image, mask, label) are plural.

@adamjstewart adamjstewart mentioned this pull request Dec 21, 2021
Closed
19 tasks
@adamjstewart adamjstewart added utilities Utilities for working with geospatial data and removed utilities Utilities for working with geospatial data labels Jan 2, 2022
yichiac pushed a commit to yichiac/torchgeo that referenced this pull request Apr 29, 2023
@nilsleh
plotting method for GID15 dataset (microsoft#288)
a8b2a8e 
* plotting method for GID15 dataset

* version added

* plot predictions

* prediction in sample
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamjstewart adamjstewart adamjstewart approved these changes

Assignees
No one assigned
Labels
datasets Geospatial or benchmark datasets
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@nilsleh @isaaccorley @calebrob6 @adamjstewart