Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GeoDataset pickling #304

Merged
merged 2 commits into from
Dec 19, 2021
Merged

Fix GeoDataset pickling #304

merged 2 commits into from
Dec 19, 2021

Conversation

adamjstewart
Copy link
Collaborator

This is an ugly hack, but it does allow users to use parallel data loading on macOS/Windows. The benchmark.py script now works on macOS with --num-workers > 0.

Fixes #184

@adamjstewart adamjstewart added the datasets Geospatial or benchmark datasets label Dec 18, 2021
isaaccorley
isaaccorley previously approved these changes Dec 18, 2021
@adamjstewart adamjstewart merged commit aaee304 into main Dec 19, 2021
@adamjstewart adamjstewart deleted the fixes/geodataset-pickle branch December 19, 2021 15:23
@adamjstewart adamjstewart added this to the 0.1.1 milestone Dec 19, 2021
adamjstewart added a commit that referenced this pull request Dec 19, 2021
* Fix GeoDataset pickling

* mypy fixes
yichiac pushed a commit to yichiac/torchgeo that referenced this pull request Apr 29, 2023
* Fix GeoDataset pickling

* mypy fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datasets Geospatial or benchmark datasets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parallel data loading doesn't work on macOS/Windows
3 participants