-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FCCD Models refactor #345
FCCD Models refactor #345
Conversation
ec26de6
to
0d31bdb
Compare
@adamjstewart I'm getting the below errors in the docs. Do you know if there's a quick fix for these? I'm basically inheriting from some segmentation_models_pytorch classes and I think it's unable to find information from the parent classes.
|
@isaaccorley you need to add smp to the |
Still can't seem to get this one to work. Wonder if it's similar to your issue with the PyTorch modules. |
Cool should be good now |
When I make the 0.3.0 release notes, remind me to add this FCEF removal as a backward incompatible change in case anyone was relying on it. Also, who was it who added these models? Should we ping them to review? (guess we should've done that before merging but it's not too late to undo anything if it's problematic) |
* remove FCEF model, refactor FCSiamConc and FCSiamDiff to inherit from smp.Unet * style fixes update tests * mypy and docstring fixes * more mypy fixes and add tests * remove test args * fix tests * add smp to intersphinx mapping * update model DOI * add the right docs this time * Removing type ignores * Testing sphinx fix * Added parts of SMP to nitpicky ignore * Fixing docs Co-authored-by: Caleb Robinson <calebrob6@gmail.com>
This PR;
FCEF
model since this is basically a U-Net with the 2 change images stacked together so the input channels are 2*num_channels.FCSiamConc
andFCSiamDiff
to inherit fromsegmentation_models_pytorch.Unet
. These models are basically U-Nets but feed both images through the U-Net encoder and then either take the difference (FCSiamDiff
) or concatenate (FCSiamConc
).Notes:
smp.Unet
constructor and it's args. ForFCSiamDiff
I made a dummy constructor so that I had a place to put the docstring. Not sure if this is the best way.