Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the GlobBiomass dataset #395

Merged
merged 11 commits into from
Feb 26, 2022
Merged

Conversation

nilsleh
Copy link
Collaborator

@nilsleh nilsleh commented Feb 12, 2022

This PR adds the GlobBiomass dataset by Santoro et al. 2018. It contains global estimates of aboveground biomass (agb) and growth stock volume (gsv) as well as corresponding standard error uncertainty maps at pixel level. The rasters have a resolution of ~100m and are 45,000x45,000px large. Dataset must be downloaded manually.

Question: In #253 I read that the RasterDatasets should get their own plot method. Should I add one to this dataset?

An updated example from the new plot method:

Screenshot from 2022-02-15 22-44-40

@nilsleh nilsleh marked this pull request as draft February 12, 2022 10:15
@github-actions github-actions bot added datasets Geospatial or benchmark datasets documentation Improvements or additions to documentation testing Continuous integration testing labels Feb 12, 2022
@adamjstewart adamjstewart added this to the 0.3.0 milestone Feb 12, 2022
@calebrob6
Copy link
Member

Question: In #253 I read that the RasterDatasets should get their own plot method. Should I add one to this dataset?

Yes, if it isn't too much trouble.

@nilsleh nilsleh marked this pull request as ready for review February 16, 2022 09:14
@calebrob6 calebrob6 closed this Feb 20, 2022
@calebrob6 calebrob6 reopened this Feb 20, 2022
Copy link
Collaborator

@adamjstewart adamjstewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry it took me so long to review this! This mostly looks good. Only remaining questions are about whether we should concatenate gsv/agb/agb_err into a single tensor and about filename_glob.

torchgeo/datasets/globbiomass.py Show resolved Hide resolved
torchgeo/datasets/globbiomass.py Show resolved Hide resolved
torchgeo/datasets/globbiomass.py Outdated Show resolved Hide resolved
torchgeo/datasets/globbiomass.py Outdated Show resolved Hide resolved
@adamjstewart adamjstewart merged commit 7e724dc into microsoft:main Feb 26, 2022
@adamjstewart adamjstewart mentioned this pull request Jul 11, 2022
yichiac pushed a commit to yichiac/torchgeo that referenced this pull request Apr 29, 2023
* globBiomass Dataset

* add tests and testdata

* add description and error messages

* doc correction

* added plot method

* orientation plot figure

* fix documentation

* add compression

* camel

* gsv fake data and filename glob

* 2 channel tensor and requested changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datasets Geospatial or benchmark datasets documentation Improvements or additions to documentation testing Continuous integration testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants