Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AsterGDEM dataset #404

Merged
merged 14 commits into from
Feb 24, 2022
Merged

Add AsterGDEM dataset #404

merged 14 commits into from
Feb 24, 2022

Conversation

nilsleh
Copy link
Collaborator

@nilsleh nilsleh commented Feb 16, 2022

This PR closes #94 by adding one DEM dataset, namely the Aster Global Digital Evaluation Map dataset. It can be manually downloaded, and there are more than 20,000 different tifs covering the globe. DEMs are at ~30m resolution and were taken by the Aster instrument.

Plot Example:

@github-actions github-actions bot added datasets Geospatial or benchmark datasets documentation Improvements or additions to documentation testing Continuous integration testing labels Feb 16, 2022
@adamjstewart adamjstewart added this to the 0.3.0 milestone Feb 18, 2022
@calebrob6 calebrob6 closed this Feb 20, 2022
@calebrob6 calebrob6 reopened this Feb 20, 2022
.. versionadded:: 0.3
"""

is_image = False
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to do right now, but I think a DEM layer could be used as an input or target

calebrob6
calebrob6 previously approved these changes Feb 21, 2022
Copy link
Collaborator

@adamjstewart adamjstewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I usually like to separate the dataset name (human-readable, informative) from the class name (short, CamelCase). Otherwise, this looks great, thanks!

docs/api/datasets.rst Outdated Show resolved Hide resolved
torchgeo/datasets/astergdem.py Outdated Show resolved Hide resolved
torchgeo/datasets/astergdem.py Outdated Show resolved Hide resolved
Co-authored-by: Adam J. Stewart <ajstewart426@gmail.com>
@adamjstewart adamjstewart merged commit d48e10e into microsoft:main Feb 24, 2022
@adamjstewart adamjstewart mentioned this pull request Jul 11, 2022
yichiac pushed a commit to yichiac/torchgeo that referenced this pull request Apr 29, 2023
* add astergdem dataset

* add astergdem dataset

* add plot method

* typo

* fix docs

* requested changes

* Update docs/api/datasets.rst

Co-authored-by: Adam J. Stewart <ajstewart426@gmail.com>

* Update torchgeo/datasets/astergdem.py

Co-authored-by: Adam J. Stewart <ajstewart426@gmail.com>

* split regex

* split regex

* split regex

* regex

Co-authored-by: Caleb Robinson <calebrob6@gmail.com>
Co-authored-by: Adam J. Stewart <ajstewart426@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datasets Geospatial or benchmark datasets documentation Improvements or additions to documentation testing Continuous integration testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DEM Dataset
3 participants