Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding SEN12MS training task #44

Merged
merged 9 commits into from
Jul 21, 2021
Merged

Adding SEN12MS training task #44

merged 9 commits into from
Jul 21, 2021

Conversation

calebrob6
Copy link
Member

Adds training support for a basic task involving the SEN12MS dataset. Train/val/test splits happen geographically, labels are the simplified MODIS IGBP labels (the first channel of labels provided in SEN12MS) used in the DFC2020 challenge.

To dos:

adamjstewart
adamjstewart previously approved these changes Jul 21, 2021
Copy link
Collaborator

@adamjstewart adamjstewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added tests, should be safe to merge now.

Hopefully it's obvious how to add tests for any new tasks you add (just add to the parametrize line). I had to modify my 2x2 test images to have the correct dimensions and band count in order for the tests to work.

I'll add a Spack package for segmentation-models-pytorch. We seem to be at the point where every new PR adds 1+ new dependencies, so we should be careful not to add too many deps.

@adamjstewart adamjstewart enabled auto-merge (rebase) July 21, 2021 15:32
@calebrob6
Copy link
Member Author

I'll add a Spack package for segmentation-models-pytorch. We seem to be at the point where every new PR adds 1+ new dependencies, so we should be careful not to add too many deps.

Agreed, segmentation-models-pytorch seems to include timm as a sub-dependency so the only other dependency I see from the training side is some object detection model set.

@adamjstewart adamjstewart merged commit e399a51 into main Jul 21, 2021
@adamjstewart adamjstewart deleted the features/train branch July 21, 2021 17:23
@adamjstewart adamjstewart added the trainers PyTorch Lightning trainers label Jul 30, 2021
@adamjstewart adamjstewart added this to the 0.1.0 milestone Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
trainers PyTorch Lightning trainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants