-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Landsat: add plot method #661
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
datasets
Geospatial or benchmark datasets
testing
Continuous integration testing
labels
Jul 10, 2022
19 tasks
github-actions
bot
added
the
documentation
Improvements or additions to documentation
label
Jul 10, 2022
How are you generating that actually? I'm getting problems:
Is giving me the following error:
Where:
|
Ahhh nvrmnd I didn't have all the bands downloaded but it was defaulting to all bands. |
calebrob6
approved these changes
Jul 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
datasets
Geospatial or benchmark datasets
documentation
Improvements or additions to documentation
testing
Continuous integration testing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We removed the
RasterDataset.plot
method in #476. Landsat was the only remainingRasterDataset
that didn't have a replacementplot
method. Added it so we don't have to explain why Landsat used to have aplot
method but no longer does.Also cleaned up some typing and documentation mistakes.
RasterDataset.__getitem__
returnsDict[str, Any]
, notDict[str, Tensor]
. Plot methods weren't added in 0.3 since they existed (albeit in the base class) in 0.2. They were changed because they now have completely different inputs.Example image from Novaya Zemlya, Russia: