-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CanadianBuildingFootprints dataset #69
Conversation
Added a notebook showing that the constructor takes 3 minutes and the @adamjstewart, can you try converting the inputs to shapefile or geopackage and see if that helps? |
Let me see if I can get conda to play nicely so I can actually run a notebook in AML. |
If you want to iterate quickly you can just use the same query:
which is in |
Good news! Things seem to be a lot faster with ESRI Shapefile. GeoJSON
ESRI Shapefile
This raises the question of how we want to support arbitrary file formats. Right now, things are hard-coded to search for We should also do some benchmarking for different file types and add that to the paper. |
I think the reason that shapefiles (or geopackages) will be fast is because they will have internal spatial indices. I don't think we should try to support geojson files as it will cause the same problems. |
Ideally, I would like to allow users to download their own data and transform it in any way. This includes:
We can certainly recommend certain file formats like COGs or Shapefiles for speed, or even issue warnings when users are using file formats with slow random access. For now, let's merge as is. When I do a |
Closes #3