Change name of arguments in Segmentation and Byol task and add timm support for Byol task #903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
testing
adamjstewart
added
the
backwards-incompatible
|
How hard would it be to split BYOL stuff and Segmentation stuff into separate PRs? |
Don't know but I can do that! But I think I would actually open two new separate PRs and remove this one. That feels the easiest. |
| .. code-block:: python | ||
|
|
||
| import timm | ||
| print(timm.list_models(pretrained=True) |
There was a problem hiding this comment.
Same here, I would suggest listing all available models:
Suggested change
| print(timm.list_models(pretrained=True) | |
| print(timm.list_models()) |
Also, you were missing a parenthesis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the argument name for the tasks according to comment in #854.
segmentation_model -> model
encoder_name -> encoder
Additionally, add timm model support for byol task.