-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add datamodule for GID-15 dataset #928
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
datamodules
PyTorch Lightning datamodules
datasets
Geospatial or benchmark datasets
documentation
Improvements or additions to documentation
testing
Continuous integration testing
labels
Dec 3, 2022
This will need the same treatment as #974 |
4 tasks
adamjstewart
force-pushed
the
datamodule/gid
branch
from
December 30, 2022 16:35
4fb5b91
to
97e6f28
Compare
adamjstewart
previously approved these changes
Dec 30, 2022
adamjstewart
previously approved these changes
Dec 30, 2022
adamjstewart
approved these changes
Dec 30, 2022
@@ -88,6 +88,8 @@ filterwarnings = [ | |||
# https://github.com/lanpa/tensorboardX/issues/653 | |||
# https://github.com/lanpa/tensorboardX/pull/654 | |||
"ignore:Call to deprecated create function:DeprecationWarning:tensorboardX", | |||
# https://github.com/kornia/kornia/issues/777 | |||
"ignore:Default upsampling behavior when mode=bilinear is changed to align_corners=False since 0.4.0:UserWarning:torch.nn.functional", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is only needed because our tests are trying to crop a 2x2 patch from a 1x1 image, which obviously requires resizing. If someone ever implements a data.py
for GID-15 and increases the image size, this can be removed.
yichiac
pushed a commit
to yichiac/torchgeo
that referenced
this pull request
Apr 29, 2023
* add datamodule with crop logic * remove print and fix batch_size * typo * Use Kornia augmentations * Style * Ignore warning Co-authored-by: Adam J. Stewart <ajstewart426@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
datamodules
PyTorch Lightning datamodules
datasets
Geospatial or benchmark datasets
documentation
Improvements or additions to documentation
scripts
Training and evaluation scripts
testing
Continuous integration testing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a datamodule for the GID-15 based on #855 with the discussed random crop logic in #876.
Closes #855