-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ship only production runtime files #378
base: main
Are you sure you want to change the base?
Conversation
oh. there's more diet to do...
note that it's all shipped twice 😛 - just the |
@microsoft-github-policy-service agree |
@iclanton - the CI seems stuck... help? |
@osher - I'll take a look this week. |
You need to run |
tsdoc/package.json
Outdated
"lib-commonjs/*.js", | ||
"lib-commonjs/*.js.map", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These (and the patterns for lib
) only match files in the root of the lib-commonjs
folder. This project has files that are in nested folders.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gotcha! will fix
will also remove the .js.map
per your comment below
...cound't get rush working for me though...
|
this will reduce your on-disk node_modules footprint from ~500K to ~80K.
I mean, good work with the tests and all, but don't ship them...
You also don't need to ship map files for
ts
.P.S.
I would put more accurate numbers like I did for
resolve
- (which BTW affects you too!), butnpm i
fails...I saw you use a different toolchain, but could not get started with this
rush
. all kinds of wierd errors... :P I had to give up.