Update ci.yml to depend more on Makefile or make.bat #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gvanrossum-ms
temporarily deployed
to
build-pipeline
GitHub Actions
Inactive
Collaborator
Author
|
Thought: Could we have a setup step that precedes the job matrix that sets an env var for invoking |
robgruen
approved these changes
Jan 13, 2026
gvanrossum-ms
temporarily deployed
to
build-pipeline
GitHub Actions
Inactive
gvanrossum-ms
requested a deployment
to
build-pipeline
GitHub Actions
Waiting
gvanrossum-ms
had a problem deploying
to
build-pipeline
GitHub Actions
Error
gvanrossum-ms
had a problem deploying
to
build-pipeline
GitHub Actions
Failure
robgruen
approved these changes
Jan 13, 2026
gvanrossum-ms
temporarily deployed
to
build-pipeline
GitHub Actions
Inactive
gvanrossum-ms
added a commit
that referenced
this pull request
Jan 13, 2026
This was a typo in #158.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically I removed the "Install dependencies" step from the Check, Format and Test jobs, in favor of the auto-create-venv behavior built into the Makefile / make.bat. Except for the Get Keys job where I had to create two Install dependencies steps, one for each platform (using
make sync/./make.bat sync).This hopefully reduces the number of times we have to change ci.yml due to some workflow change. But now we have to test this. How?