Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing deprecation: "1.8.5 contains changes that are not compatible with Node 6" #294

Closed
nicojs opened this issue Aug 30, 2021 · 3 comments

Comments

@nicojs
Copy link
Contributor

nicojs commented Aug 30, 2021

The current latest release of typed-rest-client is v1.8.5, but when you navigate to the package on NPM it states this message:

image

What does this mean? Node 6 has been end of life for about half a decade. Should I be worried when I use node 12?

Further more, if it is a problem, what should I do? I've found #291 which states that migrating back to 1.8.4 solves a problem for them. Does that mean that migrating to 1.8.4 solves it? If so, could that be stated in the deprecation message?

We're using typed-rest-client in stryker.js. Currently every user that installs Stryker sees this message:

npm WARN deprecated typed-rest-client@1.8.5: 1.8.5 contains changes that are not compatible with Node 6

@EzzhevNikita
Copy link
Contributor

Hi @nicojs, typed-rest-client contains changes related to the processing of NO_PROXY env variable (related PR) that happens with using a regular expression with the construction that is not supported in Node 6. Since this library is used by in-the-box tasks and some of them still use Node 6 we need to keep the support of this Node version. For newer versions of Node 1.8.5 there are no known issues with backward compatibility. In any way, I recommend using 1.8.4 version of typed-rest-client to get rid of this warning.

@EzzhevNikita
Copy link
Contributor

@nicojs UPD: we've published typed-rest-client@1.8.6 which contains revert the changes made in 1.8.5, so, you could just use the latest version of the package and there shouldn't be a warning message.

@nicojs
Copy link
Contributor Author

nicojs commented Aug 30, 2021

Ah thanks @EzzhevNikita. I was hoping for a solution like that. Great work. 👍

@nicojs nicojs closed this as completed Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants