Fix processing of proxybypass variables from environment #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Alexander Smolyakov <v-alsmo@microsoft.com>
Co-authored-by: Alexander Smolyakov <v-alsmo@microsoft.com>
…les' of https://github.com/microsoft/typed-rest-client into users/EzzhevNikita/fix-processing-of-proxybypass-variables
EzzhevNikita
force-pushed
the
users/EzzhevNikita/fix-processing-of-proxybypass-variables
branch
from
08acc77 to
fee8092
Compare
EzzhevNikita
requested review from
anatolybolshakov,
alexander-smolyakov and
a team
alexander-smolyakov
approved these changes
Aug 10, 2021
anatolybolshakov
approved these changes
Aug 10, 2021
EzzhevNikita
deleted the
users/EzzhevNikita/fix-processing-of-proxybypass-variables
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should address the issue with the processing of proxy bypass variables. Current logic incorrectly processes any host that is passed to NO_PROXY env variable in the format: .somehost.net. Such hosts will be wrongly interpreted because they contain points in hosts. Point is a special symbol for regex, so it should be escaped by backslash.