Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node 6, 10 and 14 to GitHub Actions and Azure Pipeline tests #296

Merged
merged 7 commits into from
Sep 14, 2021

Conversation

kuleshovilya
Copy link
Contributor

@kuleshovilya kuleshovilya commented Sep 7, 2021

Add node 6, 10 and 14 to GitHub Actions and Azure Pipeline tests, lower npm requirements in make.js due to it being unable to use node 6

@kuleshovilya kuleshovilya changed the title Add node 6, 10 and 14 to GitHub Actions and Azure Pipeline tests Add node 10 and 14 to GitHub Actions and Azure Pipeline tests Sep 7, 2021
@kuleshovilya kuleshovilya requested a review from a team September 7, 2021 12:54
@kuleshovilya kuleshovilya changed the title Add node 10 and 14 to GitHub Actions and Azure Pipeline tests Add node 6, 10 and 14 to GitHub Actions and Azure Pipeline tests Sep 9, 2021
@anatolybolshakov anatolybolshakov requested a review from a team September 10, 2021 16:16
Copy link
Contributor

@DaniilShmelev DaniilShmelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious - why do we have both github actions and azure pipelines CI? As I can see, github actions runs npm run build and npm test, and azure pipelines runs npm run units. Should we merge them/get rid of one of them?
I think it would be easiest to just add npm run units command to github actions and remove azure pipelines.
@anatolybolshakov what do you think?

@alexander-smolyakov
Copy link

Just curious - why do we have both github actions and azure pipelines CI? As I can see, github actions runs npm run build and npm test, and azure pipelines runs npm run units. Should we merge them/get rid of one of them?
I think it would be easiest to just add npm run units command to github actions and remove azure pipelines.
@anatolybolshakov what do you think?

@DaniilShmelev, the azure pipeline also publishes the build artifact that we could use later to publish the package to npm.

# publish build artifacts to drop folder so we can use them for release
- task: PublishBuildArtifacts@1
inputs:
PathtoPublish: "_build"
ArtifactName: "drop"
ArtifactType: "Container"
displayName: Publish build artifacts

Overall I agree with the idea to merge these pipelines into one and if we will decide to do this let's save the pipeline in Azure.

@kuleshovilya
Copy link
Contributor Author

@alexander-smolyakov @DaniilShmelev So, what are we deciding on? Merging both tasks, as in adding unit tests and publish build to a github actions and removing azure pipelines, while saving it to azure repo?

@alexander-smolyakov
Copy link

@kuleshovilya I would like to suggest the following approach:

  1. Merge this PR
  2. Update related Azure pipeline and remove GitHub action
  3. Open another PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants