-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add node 6, 10 and 14 to GitHub Actions and Azure Pipeline tests #296
Add node 6, 10 and 14 to GitHub Actions and Azure Pipeline tests #296
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious - why do we have both github actions and azure pipelines CI? As I can see, github actions runs npm run build
and npm test
, and azure pipelines runs npm run units
. Should we merge them/get rid of one of them?
I think it would be easiest to just add npm run units
command to github actions and remove azure pipelines.
@anatolybolshakov what do you think?
@DaniilShmelev, the azure pipeline also publishes the build artifact that we could use later to publish the package to npm. typed-rest-client/azure-pipelines.yml Lines 38 to 44 in 8bdfb96
Overall I agree with the idea to merge these pipelines into one and if we will decide to do this let's save the pipeline in Azure. |
@alexander-smolyakov @DaniilShmelev So, what are we deciding on? Merging both tasks, as in adding unit tests and publish build to a github actions and removing azure pipelines, while saving it to azure repo? |
@kuleshovilya I would like to suggest the following approach:
|
Add node 6, 10 and 14 to GitHub Actions and Azure Pipeline tests, lower npm requirements in make.js due to it being unable to use node 6