Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce Buffer copies in HttpClient #322

Merged
merged 1 commit into from
May 4, 2022
Merged

Reduce Buffer copies in HttpClient #322

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions lib/HttpClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ export class HttpClientResponse implements ifm.IHttpClientResponse {
public message: http.IncomingMessage;
readBody(): Promise<string> {
return new Promise<string>(async (resolve, reject) => {
let buffer: Buffer = Buffer.alloc(0);
const chunks = [];
const encodingCharset = util.obtainContentCharset(this);

// Extract Encoding from header: 'content-encoding'
Expand All @@ -65,8 +65,9 @@ export class HttpClientResponse implements ifm.IHttpClientResponse {

this.message.on('data', function(data: string|Buffer) {
const chunk = (typeof data === 'string') ? Buffer.from(data, encodingCharset) : data;
buffer = Buffer.concat([buffer, chunk]);
chunks.push(chunk);
}).on('end', async function() {
const buffer: Buffer = Buffer.concat(chunks);
if (isGzippedEncoded) { // Process GZipped Response Body HERE
const gunzippedBody = await util.decompressGzippedContent(buffer, encodingCharset);

Expand Down