fix error handling for decompressGzippedContent #327 #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anatolybolshakov
approved these changes
May 17, 2022
alexander-smolyakov
approved these changes
May 18, 2022
|
@mmrazik could you please review this PR? |
mmrazik
approved these changes
May 20, 2022
kirill-ivlev
deleted the
users-kirill-ivlev/fix-error-handling-for-decompressing-gzip
branch
ajuanjojjj
pushed a commit
to ajuanjojjj/typed-rest-client
that referenced
this pull request
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
link to related issue: #327
description:
Promise rejection wrapped on the single if without else clause will not stop method execution in case of the error, any other statements which go after the if block will be also executed, which confuses some of IDEs and may cause error in the future