Skip to content

Switch benchmarking commands to consistently use builtDir #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 4, 2024
Merged

Switch benchmarking commands to consistently use builtDir #46

merged 4 commits into from
Apr 4, 2024

Conversation

jakebailey
Copy link
Member

@jakebailey jakebailey commented Apr 4, 2024 •
edited
Loading

This makes use of microsoft/TypeScript#58057 to add a benchmark that can measure tsc using the public API.

As part of this change, benchmark tsc and benchmark tsserver now accept --builtDir instead of --tsc and --tsserver respectively.

@jakebailey jakebailey merged commit e29d6d9 into main Apr 4, 2024
6 checks passed
@jakebailey jakebailey deleted the tsc-via-public-api branch April 4, 2024 22:13
@jakebailey
Copy link
Member Author

Forgot to change the PR title, ugh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jakebailey