Skip to content

Increase auto-import frequency; turn off completionEntryDetails. #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2023

Conversation

DanielRosenwasser
Copy link
Member

@DanielRosenwasser DanielRosenwasser commented Mar 7, 2023

Same deal as #96, but increases the frequency of completion requests with auto-imports.

This will help us discover other issues until we can get the replay infrastructure working correctly (microsoft/typescript-server-replay#9).

@DanielRosenwasser DanielRosenwasser merged commit affdd03 into main Mar 7, 2023
@DanielRosenwasser DanielRosenwasser deleted the turnOffCompletionEntryDetails branch March 7, 2023 23:10
@DanielRosenwasser
Copy link
Member Author

Going to kick off a change on the top 150 of TS and of JS.

@DanielRosenwasser
Copy link
Member Author

The TypeScript run was dropped at microsoft/TypeScript#53159, and the JavaScript one at microsoft/TypeScript#53158

Looks like there are only a few issues left!

1 is already being fixed by @weswigham and tracked at microsoft/TypeScript#51218
2-3 are class member completion crashes
2 are mysterious SIGABRT crashes which I have no insight into - but I wonder if they're OOMs.

@MariaSolOs
Copy link

@DanielRosenwasser wait so were the dozens of completionEntry errors just false positives, or is this change just causing those to not be reported anymore?

@DanielRosenwasser
Copy link
Member Author

This change stops running completionEntryDetails requests, so people can investigate other language service bugs. As to whether the completionEntryDetails crashes were false positives, I'm still not sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants