Request completion entry details from auto-import entries. #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielRosenwasser
requested review from
andrewbranch,
gabritto and
navya9singh
| if (entry.hasAction && entry.source !== undefined && "data" in entry) { | ||
| const { name, source, data } = entry; | ||
|
|
||
| // 'completionEntryDetails' can take multiple entries; however, it's not useful for diagnostics |
There was a problem hiding this comment.
Curious to hear if others think this is bad - this is pretty likely to be slower, but I like to look at the last command and know exactly what went wrong.
I could make requests on 5 at a time in the future.
There was a problem hiding this comment.
AFAIK nobody uses the multiple-details-at-a-time command. IIRC it’s not optimized whatsoever; it just loops at the super top level and doesn’t cache anything.
andrewbranch
approved these changes
Feb 7, 2023
gabritto
approved these changes
Feb 7, 2023
navya9singh
approved these changes
Feb 7, 2023
|
microsoft/TypeScript#52660 is the first run with this enabled... and it is brutal! |
This was referenced Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also doubles the auto-import request rate from 1% to 2%.