Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON file includes do not change lowest common ancestor for outDir #660

Open
Sainan opened this issue Mar 18, 2025 · 5 comments
Open

JSON file includes do not change lowest common ancestor for outDir #660

Sainan opened this issue Mar 18, 2025 · 5 comments

Comments

@Sainan
Copy link
Contributor

Sainan commented Mar 18, 2025

Example project to reproduce the issue: repro.zip

Result when running tsgo here:

build\
  index.js

Expected result / what tsc outputs:

build\
  static\
    data.json
  src\
    index.js
@harish2704
Copy link

I also faced this same issue.
I manually copied all json files using following command rsync -a --include="*/" --include="*.json" --exclude="*" src/ lib/

Other than this issue, typescript-go was able to complete a medium sized TS project very quickly.

@Sainan
Copy link
Contributor Author

Sainan commented Mar 24, 2025

Possibly an issue with the porting of JSON includes (#565)

@jakebailey
Copy link
Member

I think this just comes down to sourceFileMayBeEmitted having a TODO for adding JSON support.

@Sainan
Copy link
Contributor Author

Sainan commented Mar 25, 2025

I don't see the TODO you speak of. 🤔

Edit: Oh, you might mean the one in emitter.go with the !!! comment.

@jakebailey
Copy link
Member

Yes, the !!! comments are "this isn't ported yet" markers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants