Bring back SourceFile.EndOfFileToken
#1257
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andarist
commented
Jun 21, 2025
| @@ -20,7 +20,6 @@ import ( | |||
| ) | |||
|
|
|||
| var testFiles = []string{ | |||
| // !!! EOFToken JSDoc parsing is missing | |||
| // filepath.Join(repo.TestDataPath, "fixtures/astnav/eofJSDoc.ts"), | |||
There was a problem hiding this comment.
even though I brought back EndOfFileToken, I'm not sure what to do here - this commented out file doesnt exist and I can't find its equivalent in Strada either
Andarist
commented
Jun 21, 2025
Comment on lines
+47
to
+50
| if parent.Kind == ast.KindEndOfFile { | ||
| p.reparseUnhosted(tag, parent, j) | ||
| continue | ||
| } |
There was a problem hiding this comment.
this seems to make sense to me that htis should be treated as unhosted JSDoc. But despite this... issues like this did not go away (yet): #1187 (comment)
I need to investigate further, cc @sandersn
Andarist
commented
Jun 21, 2025
There was a problem hiding this comment.
tbh, I don't know how to assess if this is a correct change or not
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.