Update submodule, fix JSON syntax problems #1285
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the submodule to accommodate the new type ordering changes and fixes test baselines for invalid JSON syntax. Key changes include removal of trailing commas and whitespace adjustments in JSON benchmark files as well as updates to the expected error and type outputs in several diff baselines.
Reviewed Changes
Copilot reviewed 110 out of 110 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| conformance/nodeModulesAllowJsPackagePatternExportsTrailers(module=nodenext).errors.txt.diff | Removed a trailing comma from the package JSON to fix JSON syntax issues. |
| conformance/nodeModulesConditionalPackageExports(module=nodenext).types.diff | Revised expected type outputs (e.g. switching from "any" to the correct inferred types) in alignment with the updated submodule logic. |
| Other diff files | Similar minor formatting and output adjustments across error and types baseline files to reflect updated behavior. |
Comments suppressed due to low confidence (2)
testdata/baselines/reference/submoduleAccepted/conformance/nodeModulesAllowJsPackagePatternExportsTrailers(module=nodenext).errors.txt.diff:61
- The removal of the trailing comma in the package JSON fixes invalid syntax; please ensure that similar JSON files across the baselines remain consistent with this updated syntax.
- "type": "module"
testdata/baselines/reference/submodule/conformance/nodeModulesConditionalPackageExports(module=nodenext).types.diff:1
- The expected type outputs have been updated (e.g. from 'any' to the correct type), which is aligned with the submodule changes; please verify that these new baselines accurately reflect the intended behavior.
--- old.nodeModulesConditionalPackageExports(module=nodenext).types
| >matches : Iterable<[id2: string, object]> | ||
| >x.get(id1) : Iterable<[id2: string, object]> | ||
| ->x.get : <Key extends [id1: string, id2: string] | [id1: string] | []>(...key: Key) => GetResult<[id1: string, id2: string], Key, object> | ||
| +>x.get : <Key extends [] | [id1: string] | [id1: string, id2: string]>(...key: Key) => GetResult<[id1: string, id2: string], Key, object> |
There was a problem hiding this comment.
For some reason the ordering I have in the submodule does not match for this one case. I'll have to recheck it for mistakes.
There was a problem hiding this comment.
I found one bug, but it was benign. Not sure where this difference comes from.
* Update submodule, fix JSON syntax problems (microsoft#1285) * Pool EmitContext (microsoft#1287) --------- Co-authored-by: Jake Bailey <5341706+jakebailey@users.noreply.github.com>
* Update submodule, fix JSON syntax problems (microsoft#1285) * Pool EmitContext (microsoft#1287) --------- Co-authored-by: Jake Bailey <5341706+jakebailey@users.noreply.github.com>
Pulls in the type ordering change, as well as test fixes for invalid JSON.