Override diagnostic about baseUrl path checks #1407
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the TypeScript compiler's diagnostic message for path validation to remove the confusing reference to 'baseUrl'. The diagnostic now provides a cleaner error message when non-relative paths are used in path mappings without the deprecated baseUrl option.
Key changes:
- Updated diagnostic message TS5090 to remove mention of baseUrl
- Modified diagnostic generation code to support overriding diagnostics by code rather than message text
- Updated all test baselines to reflect the new error message
Reviewed Changes
Copilot reviewed 36 out of 36 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
internal/diagnostics/extraDiagnosticMessages.json |
Added override for TS5090 diagnostic with simplified message |
internal/diagnostics/generate.go |
Refactored to override diagnostics by code instead of message text |
internal/diagnostics/diagnostics_generated.go |
Updated generated diagnostic variable name and message text |
internal/compiler/program.go |
Updated reference to use new diagnostic variable name |
testdata/baselines/reference/**/*.{js,txt,diff} |
Updated test baselines to reflect new error message |
DanielRosenwasser
approved these changes
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1381 (comment)
The diagnostic generator now lets us override diagnostics for this repo, so I dropped the mention of baseUrl.