Add missing calls to AddSyntheticLeadingComment in node builder #1607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements missing calls to AddSyntheticLeadingComment in the node builder to add /*elided*/ comments to truncated type information. The change enables proper visual indication when types have been elided for readability.
- Replaces commented-out synthetic comment code with actual calls to
AddSyntheticLeadingComment - Removes unused commented code related to the previous JSDoc rewrite system
- Updates test baselines to reflect the new comment generation behavior
Reviewed Changes
Copilot reviewed 19 out of 21 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| internal/checker/nodebuilderimpl.go | Implements synthetic comment generation for elided types and removes obsolete commented code |
| testdata/baselines/reference/submodule/* | Updated test baselines showing /*elided*/ comments now properly generated in TypeScript declarations |
jakebailey
commented
Aug 19, 2025
| getTags(c: { | ||
| - tags(c: /*elided*/ any): /*elided*/ any; | ||
| + tags(c: any): any; | ||
| tags(c: /*elided*/ any): /*elided*/ any; | ||
| }): { | ||
| - tags(c: /*elided*/ any): /*elided*/ any; | ||
| + tags(c: any): any; |
There was a problem hiding this comment.
I am unsure why this is not also fixed.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
weswigham
approved these changes
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1599 added these helpers; call them where we previously had them commented out.
I've also removed some commented out code that would have previously used the synthetic comment system, but are not longer needed due to our new JSDoc rewrite.