-
Notifications
You must be signed in to change notification settings - Fork 695
lsp: enable custom configs to be passed into tsgo LSP #1636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
lsp: enable custom configs to be passed into tsgo LSP #1636
Conversation
@microsoft-github-policy-service agree company="Canva" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enables custom configuration file names to be passed to the tsgo Language Server Protocol (LSP) implementation. The primary purpose is to allow users to specify alternative TypeScript configuration files (e.g., tsconfig.build.json
) instead of defaulting to the standard tsconfig.json
or jsconfig.json
files.
Key changes include:
- Adding
CustomConfigFileName
field to session options for configuration file customization - Implementing custom config file search logic with fallback to default behavior
- Integrating the custom config option through the VS Code extension settings and LSP initialization
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
internal/project/session.go | Adds CustomConfigFileName field to SessionOptions struct |
internal/project/configfileregistrybuilder.go | Implements custom config file search logic with fallback to standard files |
internal/lsp/server.go | Extracts custom config filename from LSP initialization options and passes to session |
_extension/src/extension.ts | Updates configuration change detection to include custom config filename setting |
_extension/src/client.ts | Passes custom config filename from VS Code settings to LSP initialization options |
_extension/package.json | Adds VS Code setting for custom config filename configuration |
Context
Address the feat request in this ticket, by allowing custom configs to be passed to the tsgo LSP.