Fix moduleDetection for node18, fix __esModule in detect=force #2045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakebailey
commented
Nov 9, 2025
...es/reference/submodule/conformance/nodeModulesAllowJsExportAssignment(module=node18).js.diff
Outdated
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in module detection logic for Node18 module kind and refactors the code for better maintainability. The original switch statement inadvertently omitted ModuleKindNode18, causing incorrect module detection behavior.
- Fixed missing
ModuleKindNode18inGetEmitModuleDetectionKind() - Refactored switch statement to range comparison for cleaner code
- Reduced test baseline diffs, indicating better convergence with TypeScript behavior
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
internal/core/compileroptions.go |
Fixed bug where ModuleKindNode18 was missing from module detection logic; refactored switch to range comparison |
testdata/baselines/reference/submodule/conformance/nodeModulesAllowJsExportAssignment(module=node18).js.diff |
Reduced diff showing convergence with TypeScript for Node18 module handling |
testdata/baselines/reference/submodule/conformance/nodeModulesAllowJsExportAssignment(module=node18).js |
Updated baseline reflecting correct Node18 behavior with __esModule marker |
testdata/baselines/reference/submodule/compiler/tripleSlashTypesReferenceWithMissingExports(module=node18).js.diff |
Eliminated diff entirely, indicating full convergence with TypeScript behavior |
testdata/baselines/reference/submodule/compiler/tripleSlashTypesReferenceWithMissingExports(module=node18).js |
Updated baseline reflecting correct Node18 module preamble emission |
jakebailey
changed the title
sheetalkamat
approved these changes
Nov 10, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
RyanCavanaugh
approved these changes
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably a typo, plus one
!!!fix.