Skip to content

Skip most CI jobs when PR is unbuildable #435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
+16 −4
Closed

Skip most CI jobs when PR is unbuildable #435

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3db7af4
Skip most CI jobs when PR is unbuildable
jakebailey Mar 10, 2025
5f2428a
Merge branch 'main' into jabaile/ci-build-dep
jakebailey Mar 11, 2025
4b262d5
Merge branch 'main' into jabaile/ci-build-dep
jakebailey Mar 14, 2025
f09182b
Merge branch 'main' into jabaile/ci-build-dep
jakebailey Mar 18, 2025
633305d
Merge branch 'main' into jabaile/ci-build-dep
jakebailey Apr 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions .github/workflows/ci.yml
View file
Original file line number Diff line number Diff line change
@@ -22,14 +22,11 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
- uses: actions/setup-node@cdca7365b2dadb8aad0a33bc7601856ffabcc48e # v4.3.0
- uses: ./.github/actions/setup-go
with:
cache-name: build

- run: npm ci

- run: npx hereby build
- run: go test -c -o=/dev/null ./...
Comment on lines -32 to +29
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still have something that actually tests hereby builds?

Copy link
Member Author

@jakebailey jakebailey Mar 10, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, but this is actually "stronger" since it checks tests. But it won't catch if the herebyfile breaks.

This PR still takes longer to build than I am expecting, probably due to the lack of build caching, so I'm not sure I even want to do this PR anymore.


extension:
runs-on: ubuntu-latest
@@ -42,6 +39,9 @@ jobs:
- run: npm run extension:build

test:
needs:
- build

strategy:
fail-fast: false
matrix:
@@ -129,6 +129,9 @@ jobs:
path: testdata/baselines/local

lint:
needs:
- build

strategy:
fail-fast: false
matrix:
@@ -173,6 +176,9 @@ jobs:
- run: npx hereby check:format

generate:
needs:
- build

runs-on: ubuntu-latest
steps:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
@@ -191,6 +197,9 @@ jobs:
- run: git diff --staged --exit-code --stat

tidy:
needs:
- build

runs-on: ubuntu-latest
steps:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
@@ -202,6 +211,9 @@ jobs:
- run: go -C ./_tools mod tidy -diff

smoke:
needs:
- build

runs-on: ubuntu-latest
steps:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2