Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misspell lint issues #462

Merged
merged 2 commits into from
Mar 17, 2025
Merged

Fix misspell lint issues #462

merged 2 commits into from
Mar 17, 2025

Conversation

alexandear
Copy link
Contributor

The PR enables misspell linter and fixes up spelling issues.

@jakebailey
Copy link
Member

To be fair, these are all typos that are present in the old codebase too 😅

@karamaru-alpha
Copy link
Contributor

karamaru-alpha commented Mar 16, 2025

It might be a good idea to create a pull request template (or contribution documentation) and mention that the typographical errors follow those in microsoft/TypeScript, so there is no need to fix them 👍

@Sainan
Copy link
Contributor

Sainan commented Mar 16, 2025

Why not just fix the typos (both upstream and here)? Where there's no problem, there's no people trying to get it fixed.

@jakebailey
Copy link
Member

I wasn't even saying "don't fix the typos", I was just joking that we're misspelling stuff everywhere 😅

Co-authored-by: Jake Bailey <5341706+jakebailey@users.noreply.github.com>
@alexandear alexandear requested a review from jakebailey March 17, 2025 10:04
@jakebailey jakebailey enabled auto-merge March 17, 2025 14:47
@jakebailey jakebailey added this pull request to the merge queue Mar 17, 2025
Merged via the queue into microsoft:main with commit 677e0f3 Mar 17, 2025
21 checks passed
@alexandear alexandear deleted the misspell branch March 17, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants