Update Windows ANSI code code based on feedback #543
Conversation
| return | ||
| } | ||
| fileType, err := windows.GetFileType(h) | ||
| if err != nil || fileType == windows.FILE_TYPE_CHAR { |
There was a problem hiding this comment.
I think it's worth noting that you need to do this to only enable virtual terminal processing if stdout hasn't been redirected. Otherwise, leave it as-is.
There was a problem hiding this comment.
Or it's possible you don't even "need" to do it? It's unclear to me what the purpose is since libuv doesn't do this.
There was a problem hiding this comment.
I think it's worth noting that you need to do this to only enable virtual terminal processing if stdout hasn't been redirected. Otherwise, leave it as-is.
The STD_OUTPUT_HANDLE is not redirected if it is a character device and GetConsoleMode succeeds. See for example dotnet's IsHandleRedirected function.
Or it's possible you don't even "need" to do it? It's unclear to me what the purpose is since libuv doesn't do this.
It is optional. I suggested this change to @jakebailey because GetConsoleMode can be slow, and GetFileType (which is much faster), helps doing the GetConsoleMode only when it is really necessary. Having said this, as enableVirtualTerminalProcessing is a one-time call, it won't make any difference.
cc @qmuntal