Skip to content

Сreate checkers in parallel #752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

auvred
Copy link
Contributor

@auvred auvred commented Apr 5, 2025

No description provided.

@Copilot Copilot AI review requested due to automatic review settings April 5, 2025 08:01
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

@auvred
Copy link
Contributor Author

auvred commented Apr 5, 2025

It seems that each checker tries to merge the globals symbol table for all program files (-race tests fail on this). I think this needs to be fixed first. However, creating 16 checkers for the vscode repository takes 50 ms on my machine. So it's not as much of an optimization as I previously thought.

@auvred auvred closed this Apr 5, 2025
@jakebailey
Copy link
Member

Oh that race is super interesting, maybe we have that race but are unable to detect it today via the way tests are set up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants