Fix some bugs in tsc -w
#781
Merged
+7
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
internal/execute/watcher.go:53
- Using reflect.DeepEqual may incur performance costs in a hot path. Consider a custom, efficient comparison function if CompilerOptions is large or performance sensitive.
if !reflect.DeepEqual(w.options.CompilerOptions(), configParseResult.CompilerOptions()) {
internal/execute/watcher.go:82
- The unconditional deletion of the file from w.prevModified might change the intended logic compared to the previous conditional deletion. Verify that this logic change is intentional and correctly handles all scenarios.
delete(w.prevModified, fileName)
iisaduan
requested changes
Apr 12, 2025
internal/execute/watcher.go
Outdated
Comment on lines
80
to
82
| } | ||
| delete(w.prevModified, fileName) | ||
| } | ||
| delete(w.prevModified, fileName) |
There was a problem hiding this comment.
It was intentional to leave this inside the if !filesModified block, since the deletion only matters if filesModified == false. You could add this reasoning into a comment in the code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #778
cc @iisaduan @jakebailey