Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration settings for html/css validation #17

Open
justinribeiro opened this issue Jul 10, 2018 · 1 comment
Open

Configuration settings for html/css validation #17

justinribeiro opened this issue Jul 10, 2018 · 1 comment
Labels
help wanted Issues identified as good community contribution opportunities

Comments

@justinribeiro
Copy link
Contributor

@sjmiles noted this in mjbvz/vscode-lit-html#42

I tried to solve this by disabling validation, i.e.

"html.validate.styles": false,
"css.validate": false
which had no effect.

Ideally ts-lit-html-plugin honors those configuration options.

With the update to StyledTemplateLanguageService, I'm wondering what your thoughts are on updating the TsHtmlPluginConfiguration interface to be enable validate and lint configuration options similar to styled? Or if there's a better configuration integration approach I'm not quite seeing.

@mjbvz mjbvz added the help wanted Issues identified as good community contribution opportunities label Nov 16, 2018
@mjbvz
Copy link
Contributor

mjbvz commented Nov 16, 2018

Yes we should at least expose a way to disable validation. I propose a setting like:

{
  "compilerOptions": {
    "plugins": [
      {
        "name": "typescript-lit-html-plugin",
        "css": { "validate": false }
      }
    ]
  }
}

The styled plugin has a number of settings that are also supported: https://github.com/Microsoft/typescript-styled-plugin#configuration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Issues identified as good community contribution opportunities
Projects
None yet
Development

No branches or pull requests

2 participants