Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

don't fetch completions on opening template tag #157

Merged
merged 1 commit into from
Dec 6, 2021
Merged

don't fetch completions on opening template tag #157

merged 1 commit into from
Dec 6, 2021

Conversation

jasonwilliams
Copy link
Contributor

@jasonwilliams jasonwilliams commented Nov 22, 2021

I found that VSCode was trying to fetch completions from typescript-styled-plugin on the opening of 2 backticks ``.
This casues some issues:

  1. Other snippets (like the expanding of the backticks) ends up getting lost in the results, and VSCode will focus on the css style you used last.
  2. Due to the amount of completions the CSS language server returns, the time taken for it to respond can be slow.
  3. The UX is not right, It's unlikely the user wants completions at this stage, they are either going to hit enter, or start typing something.

Before:
withCompletions

After:
withoutCompletions

Fixes: styled-components/vscode-styled-components#276

@mjbvz

@mjbvz
Copy link
Contributor

mjbvz commented Dec 6, 2021

Yes I agree this makes sense. Merging and will publish new build shortly

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pressing return after back-ticks does not jump to new line, selects first result of intellisense
2 participants