Skip to content

Commit

Permalink
Temporarily pin Node 20 to 20.5 to avoid Babel error (#2373)
Browse files Browse the repository at this point in the history
It looks like CI is failing due to an issue with Babel.js conflicting
with Node 20.6:

babel/babel#15927
vitejs/vite#14299

For now, let's try pinning Node 20.x to 20.5 until the issue gets fixed
in Babel.

Comparable `typespec-azure` repo PR:
https://github.com/Azure/typespec-azure/pull/3502

Issue https://github.com/Azure/typespec-azure/issues/3504 tracks the
work to un-pin the Node version.
  • Loading branch information
daviwil authored Sep 6, 2023
1 parent ae07658 commit e561be5
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 2 deletions.
4 changes: 4 additions & 0 deletions eng/pipelines/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ jobs:
vmImage: windows-2022
steps:
- template: ./templates/install.yml
parameters:
nodeVersion: "20.5"
- template: ./templates/build.yml

- script: node common/scripts/install-run-rush.js test-official --parallelism max --verbose
Expand Down Expand Up @@ -48,6 +50,8 @@ jobs:
vmImage: windows-2022
steps:
- template: ./templates/install.yml
parameters:
nodeVersion: "20.5"
- template: ./templates/build.yml

- script: node ./packages/internal-build-utils/cmd/cli.js bump-version-preview .
Expand Down
2 changes: 2 additions & 0 deletions eng/pipelines/jobs/publish-artifacts.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ jobs:
submodules: true

- template: ../templates/install.yml
parameters:
nodeVersion: "20.5"
- template: ../templates/build.yml

- script: node ./packages/internal-build-utils/cmd/cli.js bump-version-pr . --pr $(System.PullRequest.PullRequestNumber) --buildNumber $(Build.BuildNumber)
Expand Down
4 changes: 2 additions & 2 deletions eng/pipelines/pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,12 @@ jobs:
"Linux - Node 20.x":
pool: azsdk-pool-mms-ubuntu-2004-general
imageName: ubuntu-20.04
nodeVersion: "20.x"
nodeVersion: "20.5"

"Windows - Node 20.x":
pool: azsdk-pool-mms-win-2022-general
imageName: windows-2022
nodeVersion: "20.x"
nodeVersion: "20.5"

pool:
name: $(pool)
Expand Down

0 comments on commit e561be5

Please sign in to comment.