Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Completion for model properties in decorator args #1956

Closed
nguerrera opened this issue May 19, 2023 · 0 comments · Fixed by #3280
Closed

Completion for model properties in decorator args #1956

nguerrera opened this issue May 19, 2023 · 0 comments · Fixed by #3280
Labels
ide Issues for VS, VSCode, Monaco, etc.
Milestone
Backlog

Comments

@nguerrera
Copy link
Contributor

It has become common to make decorators that have signatures like this:

extern dec test(options: { one: string, two: string, })

It would be useful if you got completion for the one and two here. Essentially the equivalent of this in TypeScript:

image
@nguerrera nguerrera added ide Issues for VS, VSCode, Monaco, etc. and removed Needs Triage labels May 19, 2023
@markcowl markcowl added this to the Backlog milestone May 22, 2023
@markcowl markcowl added the 📌 label May 22, 2023
@nguerrera nguerrera changed the title Completion for model properties in decorator args Completion for model properties in decorator/template args Jun 1, 2023
@nguerrera nguerrera changed the title Completion for model properties in decorator/template args Completion for model properties in decorator args Jun 1, 2023
@RodgeFu RodgeFu mentioned this issue May 6, 2024
Merged
@bterlson bterlson removed the 📌 label May 10, 2024
github-merge-queue bot pushed a commit that referenced this issue May 17, 2024
@RodgeFu @timotheeguerin
improve completion and onhover in VSCode for decorator and extended m…
b7f6948 
…odel (#3280)

add following feature
1. support completion when user typing model expression as decorator
argument value
2. support completion for extended model
3. support showing decorator model argument prop information when
hovering on model expression as decorator argument value

closes #3130, closes #2228, closes #1956

---------

Co-authored-by: Timothee Guerin <timothee.guerin@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ide Issues for VS, VSCode, Monaco, etc.
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

improve completion and onhover in VSCode for decorator and extended model RodgeFu/typespec
3 participants
@bterlson @nguerrera @markcowl