Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The compiler is added as dependency instead of peer dependency #3632

Closed
bterlson opened this issue Jun 20, 2024 Discussed in #3625 · 1 comment
Closed

The compiler is added as dependency instead of peer dependency #3632

bterlson opened this issue Jun 20, 2024 Discussed in #3625 · 1 comment
Assignees
@sarangan12
Labels
bug Something isn't working compiler:core Issues for @typespec/compiler triaged:core
Milestone
[2024] August

Comments

@bterlson
Copy link
Member

Discussed in #3625

Originally posted by bdm-k June 20, 2024
When you create a TypeSpec emitter with the template, @typespec/compiler is added as a dependency instead of a peer dependency. However, according to the document, you should

Use peerDependencies for all TypeSpec libraries (and the compiler) that you use in your own library or emitter.

Is this intended behavior or not?

How to reproduce

  1. Install @typespec/compiler@0.57.0
  2. Run tsp init --template emitter-ts

In the generated "package.json", @typespec/compiler is added as a dependency.
@markcowl markcowl added triaged:core compiler:core Issues for @typespec/compiler labels Jun 24, 2024
@markcowl markcowl added this to the [2024] July milestone Jun 24, 2024
@markcowl markcowl added the bug Something isn't working label Jun 24, 2024
@sarangan12 sarangan12 mentioned this issue Jun 28, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jul 12, 2024
@sarangan12
Move @typespec/compiler from dependencies to peerDependencies (#3699)
982ef9a 
Per the requirement in Issue:
#3632, the dependency of
`@typespec/compiler` has to be moved from `dependencies` to
`peerDependencies`. This PR moves the dependency.
@markcowl markcowl modified the milestones: [2024] July, [2024] August Jul 15, 2024
@sarangan12
Copy link
Contributor

@markcowl @bterlson The PR has been merged for this issue. So, I believe this task can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sarangan12 sarangan12

Labels
bug Something isn't working compiler:core Issues for @typespec/compiler triaged:core
Projects
None yet
Milestone
[2024] August
Development

No branches or pull requests
4 participants
@bterlson @sarangan12 @markcowl @chrisradek