Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: tsp-openapi3: operation summaries not imported #4614

Closed
4 tasks done
Arithmomaniac opened this issue Oct 6, 2024 · 1 comment · Fixed by #4906
Closed
4 tasks done

[Bug]: tsp-openapi3: operation summaries not imported #4614

Arithmomaniac opened this issue Oct 6, 2024 · 1 comment · Fixed by #4906
Assignees
@chrisradek
Labels
feature New feature or request openapi3:converter Issues for @typespec/openapi3 openapi to typespec converter triaged:core
Milestone
[2024] November

Comments

@Arithmomaniac
Copy link

Arithmomaniac commented Oct 6, 2024 •
edited
Loading

Describe the bug

If a summary is provided on an operation in OpenAPI, it is not imported.

This may be related to #4489.

Reproduction

  • Attach a @summary decorator to an operation and see it emitted: Playground
  • Import that spec using "Import from OpenAPI 3.0" and the @summary is gone: Playground

Checklist
@Arithmomaniac Arithmomaniac added the bug Something isn't working label Oct 6, 2024
@markcowl markcowl added the emitter:openapi3 Issues for @typespec/openapi3 emitter label Oct 16, 2024
@markcowl markcowl added feature New feature or request needs-area and removed bug Something isn't working labels Oct 16, 2024
@markcowl markcowl added this to the [2024] November milestone Oct 16, 2024
@markcowl markcowl added openapi3:converter Issues for @typespec/openapi3 openapi to typespec converter and removed emitter:openapi3 Issues for @typespec/openapi3 emitter labels Oct 16, 2024
@markcowl
Copy link
Contributor

est: 3

@chrisradek chrisradek self-assigned this Oct 29, 2024
@chrisradek chrisradek mentioned this issue Oct 29, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Oct 30, 2024
@chrisradek @timotheeguerin
tsp-openapi3 - support generating summary decorator (#4906)
d768220 
Fixes #4489 and fixes #4614

This now generates the `@summary` decorator based on either the
Component schema `title` field, or the path item `summary` field.

---------

Co-authored-by: Christopher Radek <Christopher.Radek@microsoft.com>
Co-authored-by: Timothee Guerin <timothee.guerin@outlook.com>
swatkatz pushed a commit to swatkatz/typespec that referenced this issue Nov 5, 2024
@chrisradek @timotheeguerin
tsp-openapi3 - support generating summary decorator (microsoft#4906)
c3d344c 
Fixes microsoft#4489 and fixes microsoft#4614

This now generates the `@summary` decorator based on either the
Component schema `title` field, or the path item `summary` field.

---------

Co-authored-by: Christopher Radek <Christopher.Radek@microsoft.com>
Co-authored-by: Timothee Guerin <timothee.guerin@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrisradek chrisradek

Labels
feature New feature or request openapi3:converter Issues for @typespec/openapi3 openapi to typespec converter triaged:core
Projects
None yet
Milestone
[2024] November
Development

Successfully merging a pull request may close this issue.

tsp-openapi3 - support generating summary decorator chrisradek/typespec
3 participants
@Arithmomaniac @markcowl @chrisradek