Fix tsp init hanging when done due to unclosed connection #3185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timotheeguerin
requested review from
bterlson,
markcowl and
allenjzhang
as code owners
|
All changed packages have been documented.
|
|
You can try these changes at https://cadlplayground.z22.web.core.windows.net/prs/3185/ Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/prs/3185/ |
bterlson
approved these changes
Apr 22, 2024
bterlson
approved these changes
Apr 23, 2024
This was referenced Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #3102
Problem was that when following redirect we need to explicitly close the response watch otherwise we always await on it
However I switched to using
follow-redirectslibrary that will more safely handle redirect for us.(e.g. max redirects)With node 22 the fetch api should not be experimental anymore so we could potentially migrate to it next year when node 20 is out of support