Deprecate getAssetEmitter and recommend calling createAssetEmitter
directly
#3516
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #3397
Problem with calling
getAssetEmitter
is it create an asset emitter with the instance of the compiler used in the compilation and not the instance of the compiler defined in the type emitter necessarly. This cause issue withinstanceof
checks which are then not the exact same class as its loaded form different instance of the compilerCalling
createAssetEmitter
solve the issue because it is imported in teh context of the emitter package and will use the emitter package version