Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow spreading a model that has props added in previous version #3911

Merged
merged 3 commits into from
Jul 23, 2024
Merged

Allow spreading a model that has props added in previous version #3911

merged 3 commits into from
Jul 23, 2024

Conversation

timotheeguerin
Copy link
Member

@timotheeguerin timotheeguerin commented Jul 19, 2024 •
edited
Loading

fix #3639

Allow this scenario


model Base {
  @added(Versions.v1) name: string;
}

@added(Versions.v2)
model Child {
  ...Base;
}

@azure-sdk
Copy link
Collaborator

azure-sdk commented Jul 19, 2024 •
edited
Loading

All changed packages have been documented.

  • ✅ @typespec/versioning
Show changes

@typespec/versioning - fix ✏️

Allow spreading a model that has props added in previous version

@azure-sdk
Copy link
Collaborator

You can try these changes here

🛝 Playground 🌐 Website 📚 Next docs

@timotheeguerin timotheeguerin added this pull request to the merge queue Jul 23, 2024
Merged via the queue into microsoft:main with commit 10488de Jul 23, 2024
22 checks passed
@timotheeguerin timotheeguerin deleted the allow-spreading-model-previous-version branch July 23, 2024 23:08
This was referenced Aug 29, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisradek chrisradek chrisradek approved these changes

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

@markcowl markcowl Awaiting requested review from markcowl markcowl is a code owner

@allenjzhang allenjzhang Awaiting requested review from allenjzhang allenjzhang is a code owner

Assignees
No one assigned
Labels
lib:versioning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Versioned mixin properties cannot be used in a versioned model
3 participants
@timotheeguerin @azure-sdk @chrisradek