Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies #3934

Closed
wants to merge 17 commits into from
Closed

Update dependencies #3934

wants to merge 17 commits into from

Conversation

timotheeguerin
Copy link
Member

@timotheeguerin timotheeguerin commented Jul 22, 2024 •
edited
Loading

Notable:

  • vitest: 2.x
  • prettier update that does a minor formatting change by adding parentheses in some ternary expression

@azure-sdk
Copy link
Collaborator

azure-sdk commented Jul 22, 2024 •
edited
Loading

All changed packages have been documented.

  • ✅ @typespec/bundler
  • ✅ @typespec/compiler
  • ✅ @typespec/eslint-plugin
  • ✅ @typespec/html-program-viewer
  • ✅ @typespec/http-server-javascript
  • ✅ @typespec/http
  • ✅ @typespec/internal-build-utils
  • ✅ @typespec/json-schema
  • ✅ @typespec/library-linter
  • ✅ @typespec/openapi
  • ✅ @typespec/openapi3
  • ✅ @typespec/playground
  • ✅ @typespec/prettier-plugin-typespec
  • ✅ @typespec/protobuf
  • ✅ @typespec/rest
  • ✅ tmlanguage-generator
  • ✅ typespec-vscode
  • ✅ @typespec/versioning
  • ✅ @typespec/xml
Show changes

@typespec/bundler - dependencies ✏️

Update dependencies

@typespec/compiler - dependencies ✏️

Update dependencies

@typespec/eslint-plugin - dependencies ✏️

Update dependencies

@typespec/html-program-viewer - dependencies ✏️

Update dependencies

@typespec/http-server-javascript - dependencies ✏️

Update dependencies

@typespec/http - dependencies ✏️

Update dependencies

@typespec/internal-build-utils - dependencies ✏️

Update dependencies

@typespec/json-schema - dependencies ✏️

Update dependencies

@typespec/library-linter - dependencies ✏️

Update dependencies

@typespec/openapi - dependencies ✏️

Update dependencies

@typespec/openapi3 - dependencies ✏️

Update dependencies

@typespec/playground - dependencies ✏️

Update dependencies

@typespec/prettier-plugin-typespec - dependencies ✏️

Update dependencies

@typespec/protobuf - dependencies ✏️

Update dependencies

@typespec/rest - dependencies ✏️

Update dependencies

tmlanguage-generator - dependencies ✏️

Update dependencies

typespec-vscode - dependencies ✏️

Update dependencies

@typespec/versioning - dependencies ✏️

Update dependencies

@typespec/xml - dependencies ✏️

Update dependencies

@timotheeguerin timotheeguerin marked this pull request as ready for review July 23, 2024 00:52
@timotheeguerin timotheeguerin mentioned this pull request Jul 23, 2024
Merged
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

m-nash
m-nash approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@m-nash m-nash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for http-client-csharp package

@timotheeguerin timotheeguerin mentioned this pull request Jul 23, 2024
Merged
chrisradek
chrisradek reviewed Jul 23, 2024
View reviewed changes
packages/typespec-vscode/package.json
Comment on lines -34 to -37
"files": [
"typespec-vscode-*.vsix",
"ThirdPartyNotices.txt"
],
Copy link
Member

@chrisradek chrisradek Jul 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By removing this, are we including everything now? (and is that intentional?)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah the vsce tool complained that we had both files and .vscodeignore.
Vscodeignore used to take priority and files was just for the npm package that contains the vsix, so moved to use npmignore for the package

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved to this pr as this was was just failing for obscure reason #3948

github-merge-queue bot pushed a commit that referenced this pull request Jul 23, 2024
@timotheeguerin
Update dependencies (#3948)
49004b6 
New pr from this branch as it had some weird docusaurus issue not
reproducable anywhere else and just changing branch fixes it somehow
#3934
Notable:
- vitest: 2.x
- prettier update that does a minor formatting change by adding
parentheses in some ternary expression
github-merge-queue bot pushed a commit to Azure/typespec-azure that referenced this pull request Jul 23, 2024
@timotheeguerin
Update dependencies (#1219)
af5f676 
Core pr microsoft/typespec#3934
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisradek chrisradek chrisradek left review comments

@m-nash m-nash m-nash approved these changes

@JoshLove-msft JoshLove-msft Awaiting requested review from JoshLove-msft JoshLove-msft is a code owner

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

@markcowl markcowl Awaiting requested review from markcowl markcowl is a code owner

@allenjzhang allenjzhang Awaiting requested review from allenjzhang allenjzhang is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@timotheeguerin @azure-sdk @chrisradek @m-nash