Add xml support to openapi3 #4214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
skywing918
commented
Aug 20, 2024
•
skywing918
commented
- add test cases based on Examples
- add xml in OpenAPI3Schema type
- update schema-emitter logic for support xml object
skywing918
requested review from
bterlson,
markcowl,
allenjzhang and
timotheeguerin
as code owners
wanlwanl
reviewed
Aug 30, 2024
|
/azp run typespec - pr tools |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Just some message change and a question on a warning but otherwise I think this starts to look good, @chrisradek was also going to take another look to have another set of eyes to double check we implemented it respecting openapi3/typespec specs
Co-authored-by: Timothee Guerin <timothee.guerin@outlook.com>
Co-authored-by: Timothee Guerin <timothee.guerin@outlook.com>
chrisradek
reviewed
Oct 23, 2024
There was a problem hiding this comment.
Thanks for adding XML support!
Edit: Nevermind - disregard my previous post - @timotheeguerin pointed out how to rename array items using custom scalars!
timotheeguerin
approved these changes
Oct 28, 2024
swatkatz
pushed a commit
to swatkatz/typespec
that referenced
this pull request
Nov 5, 2024
1. add test cases based on [Examples](https://tspwebsitepr.z22.web.core.windows.net/prs/2982/docs/next/release-notes/xml-support.html#examples) 2. add xml in OpenAPI3Schema type 3. update schema-emitter logic for support xml object --------- Co-authored-by: Kyle Zhang <v-zhanh@microsoft.com> Co-authored-by: Timothee Guerin <timothee.guerin@outlook.com> Co-authored-by: Wanpeng Li <wanl@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.